[webkit-reviews] review granted: [Bug 23593] RenderThemeChromium[Win, Mac].cpp don't compile after renderbox changes : [Attachment 27113] [1/1] Compile fixes for RenderThemeChromiumMac and RenderThemeChromiumWin.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jan 28 11:43:07 PST 2009
Dave Hyatt <hyatt at apple.com> has granted Tony Chang (Google)
<tony at chromium.org>'s request for review:
Bug 23593: RenderThemeChromium[Win,Mac].cpp don't compile after renderbox
changes
https://bugs.webkit.org/show_bug.cgi?id=23593
Attachment 27113: [1/1] Compile fixes for RenderThemeChromiumMac and
RenderThemeChromiumWin.
https://bugs.webkit.org/attachment.cgi?id=27113&action=review
------- Additional Comments from Dave Hyatt <hyatt at apple.com>
You should add isBox() checks and bail with early returns so you don't do a bad
cast by accident. Fix that and r=me.
More information about the webkit-reviews
mailing list