[webkit-reviews] review denied: [Bug 21794] Middle-click panning should be springloaded while dragging : [Attachment 27098] Turn off pan scrolling when middle mouse button is released during a drag gesture

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has denied Loren Segal
<jinx at jinxdesign.net>'s request for review:
Bug 21794: Middle-click panning should be springloaded while dragging
https://bugs.webkit.org/show_bug.cgi?id=21794

Attachment 27098: Turn off pan scrolling when middle mouse button is released
during a drag gesture
https://bugs.webkit.org/attachment.cgi?id=27098&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
Thanks for the patch!

> +#if ENABLE(PAN_SCROLLING)
> +	   if (m_panScrollInProgress && mouseEvent.button() == MiddleButton  
> +	       && selectPanScrollCursor().impl().type() !=
middlePanningCursor().impl().type()) {

I don't think this will compile on all platforms (most platforms'
PlatformCursor types do not have a type() function).

Loren's going to refactor this patch a bit to add something like a
panScrollingDirection() function that can be used both to decide the cursor and
to decide whether to do spring-loaded scrolling.