[webkit-reviews] review requested: [Bug 22720] Make XMLHttpRequest work in Workers : [Attachment 27101] Part 5b: Add a Worker implementation for the async portion of ThreadableLoader.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 28 04:53:52 PST 2009


David Levin <levin at chromium.org> has asked  for review:
Bug 22720: Make XMLHttpRequest work in Workers
https://bugs.webkit.org/show_bug.cgi?id=22720

Attachment 27101: Part 5b: Add a Worker implementation for the async portion of
ThreadableLoader.
https://bugs.webkit.org/attachment.cgi?id=27101&action=review

------- Additional Comments from David Levin <levin at chromium.org>
This is the 2nd half of what was part 5.  All comments have been been directly
addressed.

I believe there was a lifetime issue in the code before and this has been fixed
along with a comment in the code to explain how the lifetime works.

It may have been fairly confusing before what methods were being used on each
thread so I split the WorkerThreadableLoader into two classes with each class
being used mostly on one thread to make it more clear.


More information about the webkit-reviews mailing list