[webkit-reviews] review denied: [Bug 23501] Overlapping memcpy in TestDecoder::reset : [Attachment 27074] Patch attempt for skipping assignment in reset().

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 27 09:19:34 PST 2009

Darin Adler <darin at apple.com> has denied Dean McNamee <deanm at chromium.org>'s
request for review:
Bug 23501: Overlapping memcpy in TestDecoder::reset

Attachment 27074: Patch attempt for skipping assignment in reset().

------- Additional Comments from Darin Adler <darin at apple.com>
This is the wrong level to fix this at. The TextEncoding class's assignment
operator needs to deal with this. Generally, C++ allows you to self-assign, and
it's the assignment operator's responsibility to deal with that.

I don't see how memcpy is involved at all in the compiler-generated assignment
operator. A TextEncoding has a single data member, a const char*, so I can't
imagine how memcpy gets involved. Is this something specific to some particular
platform? Perhaps you're using a misconfigured development tool that is
complaining about something that's not a real problem.

More information about the webkit-reviews mailing list