[webkit-reviews] review requested: [Bug 22720] Make XMLHttpRequest work in Workers : [Attachment 27071] Part 6: Small adjustments to the ThreadableLoader::loadResourceSynchronously to make it easier to implement for Workers

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has asked  for review:
Bug 22720: Make XMLHttpRequest work in Workers
https://bugs.webkit.org/show_bug.cgi?id=22720

Attachment 27071: Part 6: Small adjustments to the
ThreadableLoader::loadResourceSynchronously to make it easier to implement for
Workers
https://bugs.webkit.org/attachment.cgi?id=27071&action=review

------- Additional Comments from David Levin <levin at chromium.org>
For Part6: 
> I don't understand why it is desired or acceptable to lose most of the
> information in ResourceError, reducing it to an enum.

ResourceError would need a ::copy method due to contained strings.  In addition
to the overhead of this (both in code writing/maintainence/perf/etc.), XHR
doesn't use any of the info (except for what is in the enum) so nothing would
be testing this code at all. 

If anything needs more than this enum, it wouldn't be very hard to remove this
enum and do the work to copy ResourceError.


> +    auto_ptr<ResourceResponse> response;
Changed to OwnPtr. I'm not sure which one is desired here because this does get
passed in as a function param but I think OwnPtr makes the most since since it
is passed in as a OwnPtr<>&.