[webkit-reviews] review granted: [Bug 23536] Auto-generate HTMLElementFactory : [Attachment 27028] Make the platform auto-generate the file

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 26 15:14:44 PST 2009


Eric Seidel <eric at webkit.org> has granted Julien Chaffraix
<jchaffraix at pleyo.com>'s request for review:
Bug 23536: Auto-generate HTMLElementFactory
https://bugs.webkit.org/show_bug.cgi?id=23536

Attachment 27028: Make the platform auto-generate the file
https://bugs.webkit.org/attachment.cgi?id=27028&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
This looks fine to land as soon as we can better validate your differences from
the existing HTMLElementFactory.cpp

It's unclear to me what magic is used to make the HTMLElementFactory generator
not pass the tagName off to the element constructors and instead pass
pre-determined (prefix-less) HTMLName values.  Is that a hack in the generator
itself? or a special value set in the .in file?


More information about the webkit-reviews mailing list