[webkit-reviews] review requested: [Bug 23552] Dashcode evaluator no longer works after making ExecStates actual call frames : [Attachment 27052] Proposed patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jan 26 15:02:55 PST 2009
Cameron Zwarich (cpst) <cwzwarich at uwaterloo.ca> has asked for review:
Bug 23552: Dashcode evaluator no longer works after making ExecStates actual
call frames
https://bugs.webkit.org/show_bug.cgi?id=23552
Attachment 27052: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=27052&action=review
------- Additional Comments from Cameron Zwarich (cpst)
<cwzwarich at uwaterloo.ca>
There is a Radar for this, I just don't know the number. I should probably put
it in the ChangeLog.
I noticed something odd with this patch -- the global scope chain's ref count
never seems to decrease when using the evaluator. I don't see how this could
have been caused by my patch, but I should figure out why this is happening
after this patch lands and fix it.
More information about the webkit-reviews
mailing list