[webkit-reviews] review requested: [Bug 23536] Auto-generate HTMLElementFactory : [Attachment 27045] Last bits of autogeneration hackery - Updated with Eric's comment

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 26 14:05:41 PST 2009

Julien Chaffraix <jchaffraix at pleyo.com> has asked  for review:
Bug 23536: Auto-generate HTMLElementFactory

Attachment 27045: Last bits of autogeneration hackery - Updated with Eric's

------- Additional Comments from Julien Chaffraix <jchaffraix at pleyo.com>
> Seems image should just pass another parameter.  MapToTagName="img" or
> something.

I used a parameter switch here (I could not find a better name that
mapToTagName so I used it).

> +    doc->setUsesBeforeAfterRules(true);
> looks no worse than it was before, but is still not as elegant as it could
> You should add a FIXME that HTMLQuoteElements should set that flag on
> insertion instead of construction.  I bet we could make a test where you
> a Quote in one document, adopt it in another, and then before/after rules are

> not turned on for the document which adopted the quote!

I agree with you: my goal was to get it out of HTMLElementFactory.cpp as we
could miss some quote elements but the logic is wrong. I have added the
requested FIXME.

More information about the webkit-reviews mailing list