[webkit-reviews] review denied: [Bug 23536] Auto-generate HTMLElementFactory : [Attachment 27027] Last bits of auto-generation get a working generated version

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 26 12:33:18 PST 2009

Eric Seidel <eric at webkit.org> has denied Julien Chaffraix
<jchaffraix at pleyo.com>'s request for review:
Bug 23536: Auto-generate HTMLElementFactory

Attachment 27027: Last bits of auto-generation get a working generated version

------- Additional Comments from Eric Seidel <eric at webkit.org>
Seems image should just pass another parameter.  MapToTagName="img" or

+    doc->setUsesBeforeAfterRules(true);

looks no worse than it was before, but is still not as elegant as it could be.
You should add a FIXME that HTMLQuoteElements should set that flag on document
insertion instead of construction.  I bet we could make a test where you create
a Quote in one document, adopt it in another, and then before/after rules are
not turned on for the document which adopted the quote!

More information about the webkit-reviews mailing list