[webkit-reviews] review denied: [Bug 22946] [Patch] QWebPage/QWebView::selectAll to select all content : [Attachment 26167] Patch to add QWebPage/QWebView::selectAll

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has denied Urs Wolfer <uwolfer at kde.org>'s
request for review:
Bug 22946: [Patch] QWebPage/QWebView::selectAll to select all content
https://bugs.webkit.org/show_bug.cgi?id=22946

Attachment 26167: Patch to add QWebPage/QWebView::selectAll
https://bugs.webkit.org/attachment.cgi?id=26167&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
I agree that the change is straight forward, and it looks correct. But I think
this should be a function of QWebFrame only, not QWebPage or QWebView, because
the selection is a property of a frame. In a HTML frameset with many frames
each frame has its own selection.