[webkit-reviews] review denied: [Bug 22946] [Patch] QWebPage/QWebView::selectAll to select all content : [Attachment 26167] Patch to add QWebPage/QWebView::selectAll

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jan 25 07:03:31 PST 2009

Simon Hausmann <hausmann at webkit.org> has denied Urs Wolfer <uwolfer at kde.org>'s
request for review:
Bug 22946: [Patch] QWebPage/QWebView::selectAll to select all content

Attachment 26167: Patch to add QWebPage/QWebView::selectAll

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
I agree that the change is straight forward, and it looks correct. But I think
this should be a function of QWebFrame only, not QWebPage or QWebView, because
the selection is a property of a frame. In a HTML frameset with many frames
each frame has its own selection.

More information about the webkit-reviews mailing list