[webkit-reviews] review cancelled: [Bug 22624] [SOUP][GTK] Need API to get SoupSession from WebKit. : [Attachment 26836] API to retrieve and set soup sessions #6

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jan 24 08:37:12 PST 2009


Christian Dywan <christian at imendio.com> has cancelled Christian Dywan
<christian at imendio.com>'s request for review:
Bug 22624: [SOUP][GTK] Need API to get SoupSession from WebKit.
https://bugs.webkit.org/show_bug.cgi?id=22624

Attachment 26836: API to retrieve and set soup sessions #6
https://bugs.webkit.org/attachment.cgi?id=26836&action=review

------- Additional Comments from Christian Dywan <christian at imendio.com>
Changed to address the last comments.

The frame loader does keep a reference to the session now, I completely forgot
that.

The session has a flag indicating whether it was initialized, similar to
before, but the flag is on the actual message since sessions can be shuffled
around and we only want to fill it once.

Setting the session *stops* the loader, I hope it's the right way of cancelling
pending loads when exchanging the session. I did not cancel all messages on the
session because the session might be used for other frames independently.


More information about the webkit-reviews mailing list