[webkit-reviews] review granted: [Bug 23493] Introduce FormControlElementWithState abstraction : [Attachment 26955] Initial patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 23 17:41:25 PST 2009

Eric Seidel <eric at webkit.org> has granted Nikolas Zimmermann
<zimmermann at kde.org>'s request for review:
Bug 23493: Introduce FormControlElementWithState abstraction

Attachment 26955: Initial patch

------- Additional Comments from Eric Seidel <eric at webkit.org>
  if (!element->isFormControlElement())
 37	    return false;

Seems a bit strange when it's supposed to return a FormControlElement*

Strange indent:
FormControlElementWithState* toFormControlElementWithState(Element* element)
 59 {
 60	if (!element->isFormControlElementWithState())
 61		return 0;

260	 doc->registerFormElementWithState(this);
 260	FormControlElementWithState::registerFormControlElementWithState(this,
261261 }

It's a little confusing that there are both member and free versions of the
toFormControlElement function.

I'm not sure what the EventHandlingElement changes are for.

In general this looks fine though.  Please be sure to fix the tabs/indent.

More information about the webkit-reviews mailing list