[webkit-reviews] review granted: [Bug 23480] Add missing method stubs to BackForwardListChromium : [Attachment 26932] v1 submitted for review

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 23 16:06:14 PST 2009


Darin Adler <darin at apple.com> has granted Dimitri Glazkov (Google)
<dglazkov at chromium.org>'s request for review:
Bug 23480: Add missing method stubs to BackForwardListChromium
https://bugs.webkit.org/show_bug.cgi?id=23480

Attachment 26932: v1 submitted for review
https://bugs.webkit.org/attachment.cgi?id=26932&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Darin Fisher and I discussed leaving out unneeded functions intentionally,
using the linker to find the error.

Since you're submitting a patch to add these back, I guess there must be some
code that's calling these. So I don't understand why ASSERT_NOT_REACHED is OK.

You should check with Darin. But r=me


More information about the webkit-reviews mailing list