[webkit-reviews] review granted: [Bug 23492] Separating the WebKitSystemInterface Calls : [Attachment 26983] Remove calls to WebKitSystemInterface functions

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 23 15:58:01 PST 2009

Darin Adler <darin at apple.com> has granted Brent Fulgham <bfulgham at webkit.org>'s
request for review:
Bug 23492: Separating the WebKitSystemInterface Calls

Attachment 26983: Remove calls to WebKitSystemInterface functions

------- Additional Comments from Darin Adler <darin at apple.com>
> +	   https://bugs.webkit.org/show_bug.cgi?id=23492
> +	   Exclude calls to WebKitSystemInterface functions since they
> +	   are not available outside of the Apple build of WebKit.

Since they are not needed if you're not using Core Graphics. The issue here
isn't "Apple build of WebKit", it's "not calling CoreGraphics functions when
not using CoreGraphics".

>  #include <CoreGraphics/CoreGraphics.h>
> +#include <WebKitSystemInterface/WebKitSystemInterface.h>
> +#endif
>  #include <shlobj.h>
>  #include <shfolder.h>
>  #include <tchar.h>
> -#include <WebKitSystemInterface/WebKitSystemInterface.h>
>  #include <wtf/HashMap.h>
>  #include <wtf/OwnArrayPtr.h>

The PLATFORM(CG) part should go in its own separate paragraph, after the other
includes and separate by a blank line. Sorry I wasn't clear on this before.


More information about the webkit-reviews mailing list