[webkit-reviews] review granted: [Bug 23428] Frame Refactor: Move forceLayout, adjustPageHeight, forceLa. to FrameView : [Attachment 26858] Carry out the move

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Holger Freyther <zecke at selfish.org>'s
request for review:
Bug 23428: Frame Refactor: Move forceLayout,adjustPageHeight,forceLa. to
FrameView
https://bugs.webkit.org/show_bug.cgi?id=23428

Attachment 26858: Carry out the move
https://bugs.webkit.org/attachment.cgi?id=26858&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +    // We cannot unschedule a pending relayout, since the force can be
called with
> +    // a tiny rectangle from a drawRect update.  By unscheduling we in
effect
> +    // "validate" and stop the necessary full repaint from occurring. 
Basically any basic
> +    // append/remove DHTML is broken by this call.  For now, I have removed
the optimization
> +    // until we have a better invalidation stategy. -dwh
> +    //v->unscheduleRelayout();

The "v->" no longer makes sense here.

>      if (minPageWidth > 0.0)
> -	   coreFrame->forceLayoutWithPageWidthRange(minPageWidth, maxPageWidth,
adjustViewSize);
> +	   coreFrame->view()->forceLayoutWithPageWidthRange(minPageWidth,
maxPageWidth, adjustViewSize);
>      else {
> -	   coreFrame->forceLayout(!adjustViewSize);
> +	   coreFrame->view()->forceLayout(!adjustViewSize);
>	   if (adjustViewSize)
>	       coreFrame->view()->adjustViewSize();
>      }

No need to null-check view() here? Are you sure?

r=me