[webkit-reviews] review granted: [Bug 23426] Frame Refactor: Move isFrameSet to Document : [Attachment 26856] Carry out the move
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jan 23 14:18:32 PST 2009
Darin Adler <darin at apple.com> has granted Holger Freyther <zecke at selfish.org>'s
request for review:
Bug 23426: Frame Refactor: Move isFrameSet to Document
https://bugs.webkit.org/show_bug.cgi?id=23426
Attachment 26856: Carry out the move
https://bugs.webkit.org/attachment.cgi?id=26856&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
> +bool Document::isFrameSet() const
> +{
> + if (!isHTMLDocument())
> + return false;
This should be a virtual function, then, and be overridden in HTMLDocument.
That wasn't possible before when this was a function on Frame.
I'll say r=me, but it would be better to do it that way
More information about the webkit-reviews
mailing list