[webkit-reviews] review granted: [Bug 23374] Add RunLoop class to encapsulate the loop in Worker threads. : [Attachment 26906] hopefully the last version

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Dmitry Titov
<dimich at chromium.org>'s request for review:
Bug 23374: Add RunLoop class to encapsulate the loop in Worker threads.
https://bugs.webkit.org/show_bug.cgi?id=23374

Attachment 26906: hopefully the last version
https://bugs.webkit.org/attachment.cgi?id=26906&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
> + * Copyright (c) 2009, Google Inc. All rights reserved.

Please fix the copyright line, as discussed on IRC.
>      // FIXME: Rudely killing the thread won't work when we allow nested
workers, because they will try to post notifications of their destruction.
> -    m_messageQueue.kill();
> +    m_runLoop.terminate();

Do you happen to have a plan concerning this FIXME?

> +#include <WorkerRunloop.h>

Lower case "l" here, won't build on case-sensitive file systems.

r=me with these fixes.