[webkit-reviews] review denied: [Bug 23407] Implement MediaPlayerPrivate::hasVideo() on Windows : [Attachment 26958] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 23 00:49:43 PST 2009

Eric Seidel <eric at webkit.org> has denied Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 23407: Implement MediaPlayerPrivate::hasVideo() on Windows

Attachment 26958: proposed patch

------- Additional Comments from Eric Seidel <eric at webkit.org>
WebKit style would not check != NULL (or use NULL at all)...

+    return (GetMovieIndTrackType(m_private->m_movie, 1,
VisualMediaCharacteristic, movieTrackCharacteristic | movieTrackEnabledOnly) !=

Should be:
+    return GetMovieIndTrackType(m_private->m_movie, 1,
VisualMediaCharacteristic, movieTrackCharacteristic | movieTrackEnabledOnly);

Why is your test case being added to the platform/mac directory if this is a
windows test?

More information about the webkit-reviews mailing list