[webkit-reviews] review granted: [Bug 23487] Eliminate the borderTopExtra lie from RenderBox::y() : [Attachment 26950] Patch that not only passes but also progresses layout tests :)
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jan 22 19:00:50 PST 2009
Oliver Hunt <oliver at apple.com> has granted Dave Hyatt <hyatt at apple.com>'s
request for review:
Bug 23487: Eliminate the borderTopExtra lie from RenderBox::y()
https://bugs.webkit.org/show_bug.cgi?id=23487
Attachment 26950: Patch that not only passes but also progresses layout tests
:)
https://bugs.webkit.org/attachment.cgi?id=26950&action=review
------- Additional Comments from Oliver Hunt <oliver at apple.com>
r=me, afaict this looks like it should help perf, but maybe i'm mistaken.
anyhoo, r=me is conditional on perf being good.
also looking at the bit fields for m_intrinsicPaddingTop,
m_intrinsicPaddingBottom, and m_widthChanged -- i think we should look at
rearranging these to place n_widthChanged first, to reduce the liklihood that
we'll end up with either horrific load alignment and/or an unnecessary word
being added to RenderTableCell
More information about the webkit-reviews
mailing list