[webkit-reviews] review denied: [Bug 22736] State-of-art peephole state machine : [Attachment 25843] Peephole framwork with state machine

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 22 18:34:23 PST 2009

Oliver Hunt <oliver at apple.com> has denied Judit Jász <jasy at inf.u-szeged.hu>'s
request for review:
Bug 22736: State-of-art peephole state machine

Attachment 25843: Peephole framwork with state machine

------- Additional Comments from Oliver Hunt <oliver at apple.com>
While this patch looks like it would be a great addition and improvement over
the existing simplistic optimiser there are a number of issues that we'll need
to address.  The most significant of these is the use of the STL -- basically
WebKit does not use STL, and for the more complex STL structures (such as
vector, etc) we run the risk of mismatching malloc implementations.

My other concern is that the state tables appear to be hand coded, and I would
much rather we had a way to autogenerate them.

Ignoring those issues the code itself looks good (bar some minor style errors)
and probably just needs to be brought up to tip of tree (we do now have length
info for each opcode which should remove/reduce that portion of this patch).

Will CC myself to this bug so i don't miss updates.

Many apologies for the huge delay in review :-(

More information about the webkit-reviews mailing list