[webkit-reviews] review requested: [Bug 23374] Add RunLoop class to encapsulate the loop in Worker threads. : [Attachment 26905] revised patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 21 14:29:17 PST 2009


Dmitry Titov <dimich at chromium.org> has asked  for review:
Bug 23374: Add RunLoop class to encapsulate the loop in Worker threads.
https://bugs.webkit.org/show_bug.cgi?id=23374

Attachment 26905: revised patch
https://bugs.webkit.org/attachment.cgi?id=26905&action=review

------- Additional Comments from Dmitry Titov <dimich at chromium.org>
Oops, fixed couple of small things:
- removed 2008 from license text
- removed arguments to methods in .h file where their meaning can be understood
from the type
- added comment
- added ASSERT to WorkerRunLoop::run() to verify it's called on a context with
the thread and the thread is the current one


More information about the webkit-reviews mailing list