[webkit-reviews] review denied: [Bug 23435] Pass SVG spreadMethod to Gradient::platformGradient() and use it on Skia : [Attachment 26864] gradient spreadMethod patch

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has denied Evan Stade
<estade at chromium.org>'s request for review:
Bug 23435: Pass SVG spreadMethod to Gradient::platformGradient() and use it on
Skia
https://bugs.webkit.org/show_bug.cgi?id=23435

Attachment 26864: gradient spreadMethod patch
https://bugs.webkit.org/attachment.cgi?id=26864&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
This patch looks great! Though you should pass around the enum, instead of an
integer. This could be achieved by moving GradientSpreadMethod from
GraphicsContext.h to GraphicsTypes.h, and including GraphicsTypes.h in both
GraphicsContext.h and Gradient.h. What do you think?

r- because of that.