[webkit-reviews] review granted: [Bug 23433] Add InputElement abstraction : [Attachment 26866] Updated patch

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has granted Nikolas Zimmermann
<zimmermann at kde.org>'s request for review:
Bug 23433: Add InputElement abstraction
https://bugs.webkit.org/show_bug.cgi?id=23433

Attachment 26866: Updated patch
https://bugs.webkit.org/attachment.cgi?id=26866&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
> +void InputElement::notifyFormStateChanged(InputElementData& data, Document*
document)
> +{
> +    Frame* frame = document->frame();
> +    if (!frame)
> +	   return;
> +
> +    frame->page()->chrome()->client()->formStateDidChange(data.element());

I still think we should be null-checking frame->page() here.

> +class InputElementData {
> +public:
> +    InputElementData(InputElement*, Element*);

When will these two parameters not have the same value? Maybe a comment here in
the header explaining their purpose would help.

r=me