[webkit-reviews] review requested: [Bug 23431] Frame Refactor: Move methods from Frame to SelectionController : [Attachment 26861] Carry out the move.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 20 04:42:39 PST 2009


Holger Freyther <zecke at selfish.org> has asked  for review:
Bug 23431: Frame Refactor: Move methods from Frame to SelectionController
https://bugs.webkit.org/show_bug.cgi?id=23431

Attachment 26861: Carry out the move.
https://bugs.webkit.org/attachment.cgi?id=26861&action=review

------- Additional Comments from Holger Freyther <zecke at selfish.org>
It compiles, tests pass on the mac. I was hit hard by Weinig killing of
FramePrivate and need to verify the result of my git rebase actions. But
comments would be appreciated right now.

SelectionController has now two (overloaded) paintCaret implementations. This
looks fishy and I should consider merging them or making one private. I will
think about it.


More information about the webkit-reviews mailing list