[webkit-reviews] review granted: [Bug 22720] Make XMLHttpRequest work in Workers : [Attachment 26850] Remove a few more document() from xhr code (with comments addressed).
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jan 19 13:34:59 PST 2009
Alexey Proskuryakov <ap at webkit.org> has granted David Levin
<levin at chromium.org>'s request for review:
Bug 22720: Make XMLHttpRequest work in Workers
https://bugs.webkit.org/show_bug.cgi?id=22720
Attachment 26850: Remove a few more document() from xhr code (with comments
addressed).
https://bugs.webkit.org/attachment.cgi?id=26850&action=review
------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
r=me
+ // gets called after postTaskToParentContext which causes a race
condition.) TODO: Even better would be to have
+ // adapters for the parameters to do copies of them as appropriate, and
this would also fix this issue.
We don't use TODO (I'd omit this part of the comment, as it doesn't describe
any bug, just a random idea we had when discussing the code).
More information about the webkit-reviews
mailing list