[webkit-reviews] review requested: [Bug 23411] build fails for no-VIDEO config : [Attachment 26832] no-video build fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jan 18 02:18:00 PST 2009


Zalan Bujtas <zbujtas at gmail.com> has asked  for review:
Bug 23411: build fails for no-VIDEO config
https://bugs.webkit.org/show_bug.cgi?id=23411

Attachment 26832: no-video build fix
https://bugs.webkit.org/attachment.cgi?id=26832&action=review

------- Additional Comments from Zalan Bujtas <zbujtas at gmail.com>
not sure what's the policy in this case whether the newly introduced if
(style()->appearance() == MediaSliderPart) branch should go behind #if
ENABLE(VIDEO) or not.
(note that MediaSliderPart is not behind #if ENABLE(VIDEO), only the
MediaControlInputElement class is)


More information about the webkit-reviews mailing list