[webkit-reviews] review requested: [Bug 23395] Web Inpsector Debugger's Source List Should Be Sorted : [Attachment 26822] Patch 2, with binary search

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 16 19:29:28 PST 2009


boucher <rboucher at gmail.com> has asked	for review:
Bug 23395: Web Inpsector Debugger's Source List Should Be Sorted
https://bugs.webkit.org/show_bug.cgi?id=23395

Attachment 26822: Patch 2, with binary search
https://bugs.webkit.org/attachment.cgi?id=26822&action=review

------- Additional Comments from boucher <rboucher at gmail.com>
I think the 90% case is one where you don't have enough scripts to make the
performance improvement of a binary search useful (in fact you may make it
slower), and I tested it with a few hundred sources with no performance
problem.

That being said, here's a version that uses binary search. It adds the function
as a utility on Array, following the model of several other utility methods. It
takes a comparison function so its reusable by anyone interested in performing
a binary search.


More information about the webkit-reviews mailing list