[webkit-reviews] review denied: [Bug 23395] Web Inpsector Debugger's Source List Should Be Sorted : [Attachment 26813] Patch that sorts alphabetically.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 16 17:19:27 PST 2009

Oliver Hunt <oliver at apple.com> has denied boucher <rboucher at gmail.com>'s
request for review:
Bug 23395: Web Inpsector Debugger's Source List Should Be Sorted

Attachment 26813: Patch that sorts alphabetically.

------- Additional Comments from Oliver Hunt <oliver at apple.com>
That results in O(N) insertion time, and O(N^2) if there are lots of items. 
Given a loop with an eval inside it this could result in excessively poor

It is probably best to write a function that does a binary search to find the
insertion location, and then use that.

More information about the webkit-reviews mailing list