[webkit-reviews] review cancelled: [Bug 18608] [Gtk] WebKitNetworkRequest needs to be finished : [Attachment 22557] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 15 07:06:14 PST 2009


Gustavo Noronha Silva <gns at gnome.org> has cancelled Eric Seidel
<eric at webkit.org>'s request for review:
Bug 18608: [Gtk] WebKitNetworkRequest needs to be finished
https://bugs.webkit.org/show_bug.cgi?id=18608

Attachment 22557: proposed patch
https://bugs.webkit.org/attachment.cgi?id=22557&action=review

------- Additional Comments from Gustavo Noronha Silva <gns at gnome.org>
I rewrote my patch so that only the minimal functionality needed to get HTTP
information correctly fed back into WebKit when client code passes along a
WebKitNetworkRequest it received in a signal. This allows us to make it
possible for browsers such as Epihany and Midori to open links in new tabs and
still get Referer, for instance, correctly sent. Internal functionality (in
WebkitWebFrame) is also improved.

See comments bellow http://bugzilla.gnome.org/show_bug.cgi?id=120341#c12 for
more reasoning. I provide this patch now so that we can get this working sooner
rather than later, and no public API is touched, so we can discuss the merits
of my proposed API later.


More information about the webkit-reviews mailing list