[webkit-reviews] review requested: [Bug 22624] [SOUP][GTK] Need API to get SoupSession from WebKit. : [Attachment 26736] API to retrieve and set soup sessions #4

[bugzilla-daemon at webkit.org]

Christian Dywan <christian at imendio.com> has asked  for review:
Bug 22624: [SOUP][GTK] Need API to get SoupSession from WebKit.
https://bugs.webkit.org/show_bug.cgi?id=22624

Attachment 26736: API to retrieve and set soup sessions #4
https://bugs.webkit.org/attachment.cgi?id=26736&action=review

------- Additional Comments from Christian Dywan <christian at imendio.com>
Revised patch, including webkit_get_default_session and
webkit_web_view_set_session now. I haven't tested it very much. There seem to
be a race condition which leads to warnings with soup_session_get_feature.

Wrt webkit_get_global_session Vs. webkit_get_default_session, I think the
_default_ naming is pretty common, if you think of GdkScreen, GtkSettings and
such. Arguments in favour or against either are welcome.