[webkit-reviews] review requested: [Bug 16829] NPAPI: NPN_SetException() sets exception on the Global ExecState instead of local : [Attachment 26726] NPN_SetException() implementation.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 14 13:15:55 PST 2009


Jeremy Moskovich <playmobil at google.com> has asked  for review:
Bug 16829: NPAPI: NPN_SetException() sets exception on the Global ExecState
instead of local
https://bugs.webkit.org/show_bug.cgi?id=16829

Attachment 26726: NPN_SetException() implementation.
https://bugs.webkit.org/attachment.cgi?id=26726&action=review

------- Additional Comments from Jeremy Moskovich <playmobil at google.com>
This patch mirrors the exception handling done by the obj-c bindings.

The implementation ignores the NPP argument entireley which is consistent with
the Mozilla implementation, see
(http://mxr.mozilla.org/firefox/source/modules/plugin/base/src/ns4xPlugin.cpp
line 2131).

https://bugs.webkit.org/show_bug.cgi?id=19888 is also related to this issue.


More information about the webkit-reviews mailing list