[webkit-reviews] review granted: [Bug 23321] Upstream more of platform/graphics/chromium : [Attachment 26713] upstream more bits of graphics/chromium

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 14 11:13:02 PST 2009

Eric Seidel <eric at webkit.org> has granted Dimitri Glazkov (Google)
<dglazkov at chromium.org>'s request for review:
Bug 23321: Upstream more of platform/graphics/chromium

Attachment 26713: upstream more bits of graphics/chromium

------- Additional Comments from Eric Seidel <eric at webkit.org>
class FontPlatformData
 50 {
{ should be on same line.

 338 int getStyleFromLogfont(const LOGFONT* logfont) {

{ should be on its own line. :)

Sigh.  WebKit is very anti *utils files.  I wonder if we can find a happier
home for FontUtils functions.  We probably add a FIXME to the top of that file
to the effect.

More information about the webkit-reviews mailing list