[webkit-reviews] review denied: [Bug 23309] Chromium crashes with custom cursors : [Attachment 26700] Fix for the cursor crash with Chromium

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 13 18:03:15 PST 2009

Eric Seidel <eric at webkit.org> has denied Ananta Iyengar <ananta at chromium.org>'s
request for review:
Bug 23309: Chromium crashes with custom cursors

Attachment 26700: Fix for the cursor crash with Chromium

------- Additional Comments from Eric Seidel <eric at webkit.org>
The ChangeList wrong.  You you set EMAIL_ADDRESS in your local environment so
future runs of prepare-ChangeLog know what your email address is
(iyengar at chromium.org).  Your REAL_NAME value should also be set to something
other than "iyengar" (currently it's falling back onto your username).	I would
revert your local ChangeLog and run prepare-ChangeLog again (once and only

You seem to have corrected setData to 8 spaces of indent from 6 spaces on all
platforms except chromium. :)

More information about the webkit-reviews mailing list