[webkit-reviews] review granted: [Bug 23178] offsetTop is wrong in some cases : [Attachment 26647] Include layout test and expected result for the proposed patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Grace Kloba <klobag at gmail.com>'s
request for review:
Bug 23178: offsetTop is wrong in some cases
https://bugs.webkit.org/show_bug.cgi?id=23178

Attachment 26647: Include layout test and expected result for the proposed
patch
https://bugs.webkit.org/attachment.cgi?id=26647&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +	https://bugs.webkit.org/show_bug.cgi?id=23178
> +	Added a case to test the offsetTop of table cell's children.

There are tabs here, which make it hard to land the patch.

> +			<div style="margin: 50pt 0pt 50pt 0pt;"></div>

You want px here, not pt. I'm surprised the test works if you're specifying pt,
since they are not the same as px.

Did you try the test case in other browsers? Does Firefox give the same
results?

I'm going to say r=me but I am slightly worried about the pt in the test case.
And I want to be sure we're matching the other browsers here -- the fix looks
clearly right, but I'd like to see the test to be sure.