[webkit-reviews] review granted: [Bug 23254] Upstream page/chromium/ : [Attachment 26634] v1 patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Darin Fisher (Google)
<darin at chromium.org>'s request for review:
Bug 23254: Upstream page/chromium/
https://bugs.webkit.org/show_bug.cgi?id=23254

Attachment 26634: v1 patch
https://bugs.webkit.org/attachment.cgi?id=26634&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Shouldn't ChromeClientChromium just be part of ChromeClient?  It seems we
should either move that one function to ChromeClient, or at least add a FIXME
to do so (or a comment explaining why ChromeClientChromium should be separate).


Also ChromeClientChromium.h uses #ifndef ChromeClientWin

+    // FIXME: To match the macos behaviour we should return DragOperationNone

MacOS or mac os, but macos reads strange to me. :)

+bool DragController::isCopyKeyDown() {

{ on new line

Otherwise looks good.  Sad that chrome doesn't support drag images. :(