[webkit-reviews] review granted: [Bug 23254] Upstream page/chromium/ : [Attachment 26634] v1 patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 12 11:14:17 PST 2009

Eric Seidel <eric at webkit.org> has granted Darin Fisher (Google)
<darin at chromium.org>'s request for review:
Bug 23254: Upstream page/chromium/

Attachment 26634: v1 patch

------- Additional Comments from Eric Seidel <eric at webkit.org>
Shouldn't ChromeClientChromium just be part of ChromeClient?  It seems we
should either move that one function to ChromeClient, or at least add a FIXME
to do so (or a comment explaining why ChromeClientChromium should be separate).

Also ChromeClientChromium.h uses #ifndef ChromeClientWin

+    // FIXME: To match the macos behaviour we should return DragOperationNone

MacOS or mac os, but macos reads strange to me. :)

+bool DragController::isCopyKeyDown() {

{ on new line

Otherwise looks good.  Sad that chrome doesn't support drag images. :(

More information about the webkit-reviews mailing list