[webkit-reviews] review denied: [Bug 23245] REGRESSION: Use of JavaScriptCore C API without using WebKit leads to immediate crash inside JSC::Identifier::add : [Attachment 26624] Patch with the comments addressed.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Jan 11 21:41:11 PST 2009
Darin Adler <darin at apple.com> has denied David Levin <levin at chromium.org>'s
request for review:
Bug 23245: REGRESSION: Use of JavaScriptCore C API without using WebKit leads
to immediate crash inside JSC::Identifier::add
https://bugs.webkit.org/show_bug.cgi?id=23245
Attachment 26624: Patch with the comments addressed.
https://bugs.webkit.org/attachment.cgi?id=26624&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
Oh, I am so evil. I told you to move it into JSStringCreate functions,
*knowing* you'd probably missing JSStringCreateWithBSTR. But did I say
anything? No! So I made you take a perfectly good, working patch, and ruin it.
review-, but I'm sure it will take you like 10 seconds to fix it
More information about the webkit-reviews
mailing list