[webkit-reviews] review denied: [Bug 23245] REGRESSION: Use of JavaScriptCore C API without using WebKit leads to immediate crash inside JSC::Identifier::add : [Attachment 26622] Fix for bug.

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied David Levin <levin at chromium.org>'s
request for review:
Bug 23245: REGRESSION: Use of JavaScriptCore C API without using WebKit leads
to immediate crash inside JSC::Identifier::add
https://bugs.webkit.org/show_bug.cgi?id=23245

Attachment 26622: Fix for bug.
https://bugs.webkit.org/attachment.cgi?id=26622&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
I think it's subtle and non-obvious that OpaqueJSString::ustring is a suitable
bottleneck, yet OpaqueJSString::identifier, a function with a nearly identical
purpose, doesn't need the initializeThreading call. I think it might be better
to initialize in the individual JSStringCreate functions, even though there are
many of them, because the subtle relationship between the external functions
and the reason OpaqueJSString has initialization inside it is very likely to
get broken in the future even though it's fine right now.

You missed JSGlobalContextCreateInGroup, which can take NULL for the group.

prepare-ChangeLog somehow missed JSGlobalContextCreate, because it's not listed
in your change log.

I'm going to say review- because you missed JSGlobalContextCreateInGroup.