[webkit-reviews] review granted: [Bug 20766] Unable to resize deeply nested frames : [Attachment 26607] New version which uses localToAbsolute and adds layout test

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jan 11 11:46:38 PST 2009


Darin Adler <darin at apple.com> has granted Adam Treat <treat at kde.org>'s request
for review:
Bug 20766: Unable to resize deeply nested frames
https://bugs.webkit.org/show_bug.cgi?id=20766

Attachment 26607: New version which uses localToAbsolute and adds layout test
https://bugs.webkit.org/attachment.cgi?id=26607&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +	       function init() {
> +		   if (window.layoutTestController) {
> +		       //Move the last horizontal resizer ten pixels south...
> +		       eventSender.mouseMoveTo(400, 393);
> +		       eventSender.mouseDown();
> +		       eventSender.mouseMoveTo(400, 403);
> +		       eventSender.mouseUp();
> +		   }
> +	       }

I'd like this test better if it used dumpAsText instead of a render tree dump
for its results.

Fix looks great!

I'm going to say r=me on this as is, but please work on an even-better test if
you're willing to.


More information about the webkit-reviews mailing list