[webkit-reviews] review granted: [Bug 23237] Some HTML constructors in HTMLElementFactory needs an HTMLFormElement argument : [Attachment 26604] Proposed fix: add a new parameter to make_names
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Jan 11 09:00:02 PST 2009
Darin Adler <darin at apple.com> has granted Julien Chaffraix
<jchaffraix at pleyo.com>'s request for review:
Bug 23237: Some HTML constructors in HTMLElementFactory needs an
HTMLFormElement argument
https://bugs.webkit.org/show_bug.cgi?id=23237
Attachment 26604: Proposed fix: add a new parameter to make_names
https://bugs.webkit.org/attachment.cgi?id=26604&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
r=me
I think the "=1" in the syntax aren't so great.
constructorNeedsCreatedByParser=1 should just be
constructorNeedsCreatedByParser and constructorNeedsFormElement=1 should just
be constructorNeedsFormElement
More information about the webkit-reviews
mailing list