[webkit-reviews] review denied: [Bug 23024] Crash beneath addOverhangingFloats() at trazi.appspot.com : [Attachment 26539] fix the crash for referencing deleted floating objects

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jan 10 14:35:51 PST 2009


Darin Adler <darin at apple.com> has denied Hin-Chung Lam <hclam at google.com>'s
request for review:
Bug 23024: Crash beneath addOverhangingFloats() at trazi.appspot.com
https://bugs.webkit.org/show_bug.cgi?id=23024

Attachment 26539: fix the crash for referencing deleted floating objects
https://bugs.webkit.org/attachment.cgi?id=26539&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
The fix looks great. Normally we require a regression test with every bug fix.
How did you discover this bug? Can you write a regression test for it?

> +	   Reviewed by NOBODY (OOPS!).
> +
> +	  https://bugs.webkit.org/show_bug.cgi?id=23024
> +
> +	  Remove an incorrect criteria in the if statement that leaves
references to deleted floating object in RenderBlock.

These aren't indented right. Need 8 spaces instead of 7.

I'm going to say review- because of the lack of a regression test.


More information about the webkit-reviews mailing list