[webkit-reviews] review denied: [Bug 23178] offsetTop is wrong in some cases : [Attachment 26570] patch with layout test file

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jan 10 10:28:46 PST 2009

Darin Adler <darin at apple.com> has denied Grace Kloba <klobag at gmail.com>'s
request for review:
Bug 23178: offsetTop is wrong in some cases

Attachment 26570: patch with layout test file

------- Additional Comments from Darin Adler <darin at apple.com>
Looking good.

> +2009-01-09  Grace Kloba  <klobag at gmail.com>
> +
> +	https://bugs.webkit.org/show_bug.cgi?id=23178
> +	Added a case to test the offsetTop of table cell's children.
> +
> +	   * fast/dom/Element/offsetTop-table-cell.html:

This change log entry has tabs in it. We need one that uses spaces instead.

> Index: LayoutTests/fast/dom/Element/offsetTop-table-cell.html
> ===================================================================
> --- LayoutTests/fast/dom/Element/offsetTop-table-cell.html	(revision
> +++ LayoutTests/fast/dom/Element/offsetTop-table-cell.html	(working copy)

Since this test has changed, then the expected results have also changed. We
need a patch that includes the changes to the expected results files too.

More information about the webkit-reviews mailing list