[webkit-reviews] review requested: [Bug 22995] REGRESSION: radar loops don't animate : [Attachment 26552] patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 8 17:29:30 PST 2009


Peter Kasting <pkasting at google.com> has asked  for review:
Bug 22995: REGRESSION: radar loops don't animate
https://bugs.webkit.org/show_bug.cgi?id=22995

Attachment 26552: patch v1
https://bugs.webkit.org/attachment.cgi?id=26552&action=review

------- Additional Comments from Peter Kasting <pkasting at google.com>
This isn't tested, but if smfr is correct about the cause of the flakiness (and
it certainly looks like a problem to me too), this should fix it, and in a more
robust way than the proposed workaround of forcing the frame to re-cache in
startAnimation().

This clears the frame's metadata if we get more data for it.  This should match
fairly well with when the metadata _can_ actually change (it's just slightly
aggressive in clearing the metadata, but not in a way that will have any real
effect).


More information about the webkit-reviews mailing list