[webkit-reviews] review cancelled: [Bug 23175] String and UString should be able to share a UChar* buffer. : [Attachment 26515] Patch for bug.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 8 17:06:22 PST 2009


David Levin <levin at chromium.org> has cancelled David Levin
<levin at chromium.org>'s request for review:
Bug 23175: String and UString should be able to share a UChar* buffer.
https://bugs.webkit.org/show_bug.cgi?id=23175

Attachment 26515: Patch for bug.
https://bugs.webkit.org/attachment.cgi?id=26515&action=review

------- Additional Comments from David Levin <levin at chromium.org>
This has all known changes done to it.

There is one known issue with the change:
JavaScriptCore/wtf/SharedDataHolder.h no longer matches the contents of the
file.

This means that I should change the name of the file and the references to it
in various places (build files, includes, and ChangeLog).  However, in case
there is more feedback about the naming of this class, I avoid those changes
for the moment.


More information about the webkit-reviews mailing list