[webkit-reviews] review requested: [Bug 22929] Memory Regression from r39309 : [Attachment 26542] memory regression patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 8 16:01:07 PST 2009

Peter Kasting <pkasting at google.com> has asked  for review:
Bug 22929: Memory Regression from r39309

Attachment 26542: memory regression patch v1

------- Additional Comments from Peter Kasting <pkasting at google.com>
My fix for bug 22108 was helpful for non-CG backends, but with further testing
looks to have been totally useless for CG, which apparently scans as much of
the GIF as it needs to determine the repetition count.	Since that's true, it
won't make animation any flakier to go ahead and destroy the decoder after each
frame if the image is large.

In theory, the CG decoder could use the images it's reffed to speed decoding of
later frames, which means this would trade off lower memory usage for higher
CPU usage; and if the decoder wasn't extremely aggressive about throwing away
frames internally during decoding, even the memory savings wouldn't be true
savings, as transiently memory would spike that high anyway.  However, the CG
decoder doesn't seem to use these frames that way, so keeping them doesn't save

More information about the webkit-reviews mailing list