[webkit-reviews] review cancelled: [Bug 20534] DumpRenderTree needs a way to override settings on a per-test basis : [Attachment 26328] Revised patch to issue 20534

[bugzilla-daemon at webkit.org]

Glenn Wilson <gwilson at google.com> has cancelled Glenn Wilson
<gwilson at google.com>'s request for review:
Bug 20534: DumpRenderTree needs a way to override settings on a per-test basis
https://bugs.webkit.org/show_bug.cgi?id=20534

Attachment 26328: Revised patch to issue 20534
https://bugs.webkit.org/attachment.cgi?id=26328&action=review

------- Additional Comments from Glenn Wilson <gwilson at google.com>
Here is an improved version of the previous patch.  This version does not use
Objective-C 2.0 behavior (specifically, for(in) loops) in WebPreferences.

Eric and I were talking last night on IRC about a different approach to this
patch -- specifically keeping all overridden values in a separate dictionary,
so there is no risk of any overridden values being saved to disk.  I'm hoping
to experiment with this in another patch.