[webkit-reviews] review granted: [Bug 22614] Need to add Win32 implementation of ThreadSpecific. : [Attachment 26502] Proposed Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 8 05:44:21 PST 2009

Alexey Proskuryakov <ap at webkit.org> has granted Jian Li <jianli at chromium.org>'s
request for review:
Bug 22614: Need to add Win32 implementation of ThreadSpecific.

Attachment 26502: Proposed Patch

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
> + * WebKit the repeated call bahavior is utilized.

Typo: "bahavior".

> +#include "config.h"
> +
> +#include "ThreadSpecific.h"

The coding style asks for an empty line after ThreadSpecific.h, not after

> +		// The layout of ThreadSpecific<T>::Data does not depend on T.
So we are safe to do the static cast to ThreadSpecific<int> in order to access
its data member.

Please use spaces for indenting, not tabs.

r=me, I'm going to fix these minor details before landing.

More information about the webkit-reviews mailing list