[webkit-reviews] review requested: [Bug 18835] spelling underlines disappear when they shouldn't : [Attachment 26522] A Quick Fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 8 00:04:12 PST 2009

Hironori Bono <hbono at chromium.org> has asked  for review:
Bug 18835: spelling underlines disappear when they shouldn't

Attachment 26522: A Quick Fix

------- Additional Comments from Hironori Bono <hbono at chromium.org>
I accidentally noticed a cause of this bug while investigating another issue.
Somehow the InsertLineBreakCommand::doApply() function forgot copying markers
while splitting a text node with a line-break key even though there is a
CompositeEditCommand::splitTextNode() function, which splits a text node and
copy markers.
I'm not sure it is correct to call the CompositeEditCommand::splitTextNode()
function here, though.

More information about the webkit-reviews mailing list