[webkit-reviews] review requested: [Bug 22795] favicons should be saved to webarchives : [Attachment 26519] Patch v3 (there is no Patch v2)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 7 18:50:18 PST 2009

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked  for review:
Bug 22795: favicons should be saved to webarchives

Attachment 26519: Patch v3 (there is no Patch v2)

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
Patch v2 was an internal patch which never saw the light of day.

Changes since Patch v1:

- Fixed data.release() issue from Comment #2.

- Fixed bug in IconDatabase::close() so that the method actually closes the
internal SQLite database.  This makes isOpen() report the correct state
immediately afterward calling close().

- Worked around <rdar://problem/6480108> in LayoutTestControllerMac.mm and
LayoutTestControllerWin.cpp.  (Basically, [[WebIconDatabase sharedIconDatabase]
setEnabled:FALSE] doesn't work because getting the shared instance for the
first time enables the database, and disabling it right away doesn't work. 
Instead, DumpRenderTree assumes it's the only client using the WebIconDatabase,
and that the icon database is disabled until [WebIconDatabase
sharedIconDatabase] is called.)

More information about the webkit-reviews mailing list