[webkit-reviews] review granted: [Bug 23127] Misuses of pango_coverage_get and pango_coverage_from_bytes. : [Attachment 26449] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 7 16:48:24 PST 2009


Holger Freyther <zecke at selfish.org> has granted Hiroyuki Ikezoe
<poincare at ikezoe.net>'s request for review:
Bug 23127: Misuses of pango_coverage_get and pango_coverage_from_bytes.
https://bugs.webkit.org/show_bug.cgi?id=23127

Attachment 26449: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=26449&action=review

------- Additional Comments from Holger Freyther <zecke at selfish.org>
> Index: WebCore/ChangeLog
> ===================================================================
> --- WebCore/ChangeLog (revision 39635)
> +++ WebCore/ChangeLog (working copy)
> @@ -1,3 +1,14 @@
> +2009-01-05  Hiroyuki Ikezoe	<poincare at ikezoe.net>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	Invoke pango_coverage_get with each Unicode character.

please don't use tabs. Could you please also tell me what is broken with the
other way of doing it? How you spotted it?


More information about the webkit-reviews mailing list