[webkit-reviews] review cancelled: [Bug 23092] Conditionalize CFNetwork-specific logic in WebKit.dll : [Attachment 26399] Patch to conditionalize CFNetwork/cURL logic

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at gmail.com> has cancelled Brent Fulgham
<bfulgham at gmail.com>'s request for review:
Bug 23092: Conditionalize CFNetwork-specific logic in WebKit.dll
https://bugs.webkit.org/show_bug.cgi?id=23092

Attachment 26399: Patch to conditionalize CFNetwork/cURL logic
https://bugs.webkit.org/attachment.cgi?id=26399&action=review

------- Additional Comments from Brent Fulgham <bfulgham at gmail.com>
This patch moves the CFNetwork-specific logic into separate files, and provides
initial cURL-based stub files to be filled in with logic in a subsequent
update.
* A handful of files were not split, as they only had one or two lines that had
to be conditionally compiled.  E.g., WebURLAuthenticationChallenge.  An
cURL-specific AuthenticationChallenge object should render this uniform across
both implementations.
* Project file has been updated so the CFNet files are excluded for cURL
builds, and vice versa.

The patch has been tested against my Cairo/cURL build and a stock Apple
Safari-based build.